Codecov Report

Merging #20276 (fdbf0d7) into master (ead1040) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #20276      +/-   ##
==========================================
+ Coverage   66.69%   66.70%   +0.01%     
==========================================
  Files        1739     1739              
  Lines       65153    65139      -14     
  Branches     6903     6897       -6     
==========================================
+ Hits        43453    43454       +1     
+ Misses      19947    19932      -15     
  Partials     1753     1753              

Flags with carried forward coverage won't be shown. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ead1040...fdbf0d7. Read the comment docs.

While this fixes the missing class, and I appreciate the contribution to resolve that, there are a couple things that are holding me up from approving/merging.

1. The .m-r-10 definition exists in SQL Lab's main.less file, so if we were to go global with it, we should remove that in favor of the one you're adding.

2. It looks like this class is only actually used in a couple places. It'd probably be better to style those two components with Emotion rather than adding more LESS (which we're trying to whittle away at)

3. To confuse things further... I kind of LIKE the layout of the Before picture better... everything is nicely right aligned. Maybe we should just get rid of this margin once and for all? It sounds like you were solving a code problem more than a cosmetic problem, but let me know if I'm misinterpreting.

While this fixes the missing class, and I appreciate the contribution to resolve that, there are a couple things that are holding me up from approving/merging.

1. The .m-r-10 definition exists in SQL Lab's main.less file, so if we were to go global with it, we should remove that in favor of the one you're adding.
2. It looks like this class is only actually used in a couple places. It'd probably be better to style those two components with Emotion rather than adding more LESS (which we're trying to whittle away at)
3. To confuse things further... I kind of LIKE the layout of the Before picture better... everything is nicely right aligned. Maybe we should just get rid of this margin once and for all? It sounds like you were solving a code problem more than a cosmetic problem, but let me know if I'm misinterpreting.

I found this problem when I was trying to add another Button on the right side after the one showing in the picture, and there was no margin between these two Button which should be there because both Button had '.m-r-10' class. So I raised up this issue.

But just as you mentioned, it looks nicely right aligned so maybe all those buttons should be removed from '.m-r-10' class? or use '.m-l-10' instead.

And maybe it is another good way to globalize SQL Labs' less file.

It looks like this class is only actually used in a couple places. It'd probably be better to style those two components with Emotion rather than adding more LESS (which we're trying to whittle away at)

I think this is the best solution.

I found this problem when I was trying to add another Button on the right side after the one showing in the picture, and there was no margin between these two Button which should be there because both Button had '.m-r-10' class.

That's a valid use case. We just need to fix it using Emotion instead of LESS.

/testenv up

@michael-s-molina Ephemeral environment spinning up at http://52.13.42.77:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Ephemeral environment shutdown and build artifacts deleted.